Apply suggestions from code review

The rest of the suggestions will be addressed in my local repo and pushed back

Co-authored-by: Håvard Gjøby Thom <34199185+havardthom@users.noreply.github.com>
This commit is contained in:
davalanche 2024-11-29 16:44:38 -06:00 committed by GitHub
parent d58a338765
commit 5c7da4f2f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions

View File

@ -16,7 +16,6 @@ cat <<"EOF"
/ / / / /_/ / / /_/ / / ___/ / / / / / /_/ / / /_/ / / ___/ /
/_/ /_/\__, /_/\__,_/_/ /____/ /_/ /_/\__, /_/\__,_/_/ /____/
/____/ /____/
EOF EOF
} }
header_info header_info

View File

@ -28,18 +28,17 @@ rm /etc/apt/sources.list.d/non-free.list
msg_ok "Installed Dependencies" msg_ok "Installed Dependencies"
msg_info "Installing ${APPLICATION}" msg_info "Installing ${APPLICATION}"
mkdir -p /opt/mylar3 && mkdir -p /opt/mylar3-data mkdir -p /opt/mylar3
mkdir -p /opt/mylar3-data
$STD git clone -b master https://github.com/mylar3/mylar3.git /opt/mylar3 $STD git clone -b master https://github.com/mylar3/mylar3.git /opt/mylar3
rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED
$STD pip install -U --no-cache-dir pip $STD pip install -U --no-cache-dir pip
$STD pip install --no-cache-dir -r /opt/mylar3/requirements.txt $STD pip install --no-cache-dir -r /opt/mylar3/requirements.txt
msg_ok "Installed ${APPLICATION}" msg_ok "Installed ${APPLICATION}"
msg_info "Creating Service" msg_info "Creating Service"
# Reference: /opt/mylar3/init-scripts/systemd/mylar.service
cat <<EOF >/etc/systemd/system/mylar3.service cat <<EOF >/etc/systemd/system/mylar3.service
[Unit] [Unit]
Description=Systemd script to run Mylar3 as a service Description=Mylar3 Service
After=network-online.target After=network-online.target
[Service] [Service]