From 5c7da4f2f9a1f990a413647fdb90670ae162c348 Mon Sep 17 00:00:00 2001 From: davalanche Date: Fri, 29 Nov 2024 16:44:38 -0600 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The rest of the suggestions will be addressed in my local repo and pushed back Co-authored-by: Håvard Gjøby Thom <34199185+havardthom@users.noreply.github.com> --- ct/mylar3.sh | 1 - install/mylar3-install.sh | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ct/mylar3.sh b/ct/mylar3.sh index c67526ce..0d2e4833 100644 --- a/ct/mylar3.sh +++ b/ct/mylar3.sh @@ -16,7 +16,6 @@ cat <<"EOF" / / / / /_/ / / /_/ / / ___/ / /_/ /_/\__, /_/\__,_/_/ /____/ /____/ - EOF } header_info diff --git a/install/mylar3-install.sh b/install/mylar3-install.sh index 1f6f2222..8352127e 100644 --- a/install/mylar3-install.sh +++ b/install/mylar3-install.sh @@ -28,18 +28,17 @@ rm /etc/apt/sources.list.d/non-free.list msg_ok "Installed Dependencies" msg_info "Installing ${APPLICATION}" -mkdir -p /opt/mylar3 && mkdir -p /opt/mylar3-data +mkdir -p /opt/mylar3 +mkdir -p /opt/mylar3-data $STD git clone -b master https://github.com/mylar3/mylar3.git /opt/mylar3 -rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED $STD pip install -U --no-cache-dir pip $STD pip install --no-cache-dir -r /opt/mylar3/requirements.txt msg_ok "Installed ${APPLICATION}" msg_info "Creating Service" -# Reference: /opt/mylar3/init-scripts/systemd/mylar.service cat </etc/systemd/system/mylar3.service [Unit] -Description=Systemd script to run Mylar3 as a service +Description=Mylar3 Service After=network-online.target [Service]