diff --git a/notes/apikeys.md b/notes/apikeys.md index 49ed7b3..e659885 100644 --- a/notes/apikeys.md +++ b/notes/apikeys.md @@ -33,6 +33,20 @@ Silver.Echo.040 Jade.Antares.379 Purple.Venus.729 +Utah+Iron+599 + +Arizona~Sapphire~491 + +Red+Taurus+477 + +Arizona$Zulu$713 + +Indigo+Xray+417 + +Crimson~Terra~731 + +Crimson-Copper-646 + Orions Wordpress Admin password ``` d#rV)cxMNCQBoCAm*S diff --git a/work/Comcarde/tasks/bridge_592/commit.md b/work/Comcarde/tasks/bridge_592/commit.md new file mode 100644 index 0000000..890740e --- /dev/null +++ b/work/Comcarde/tasks/bridge_592/commit.md @@ -0,0 +1,79 @@ +BRIDGE-592: Use validated `req.swagger.params.body.value` + +# Summary + +`req.body` is incorrectly being used in multiple places in the controllers for the /dev/ API. + +These should be changed to use `req.swagger.params.body.value` which is the properly validated version. + +Anything which was just a `req.body` was changed to `req.swagger.params.body.value`. + +This affected: +`worldpayPayment`, +`saveCardDetails`, +`saveWorldpayReceivingAccount`, +`makeWorldpayPaymentWithSavedCard` + +# Details + +Any additional details. Specific technical points, etc. + +# Test Plan + +* Unit tests run and pass +* Manual tests for the following were performed + + +**Make a worldpay payment.** /payments/worldpay + +Code 200 + +Response body + +```json +{ + "transaction": { + "id": "58b243a2-0d37-4205-a24d-f606a914124e" + } +} +``` + +**Save card details.** /payment-instruments/cards + +Code 201 + +Response body + +```json +{ + "cardUsageKey": "b8a1b1fc-31f2-42f3-be87-8a17b5145ea1", + "cardID": "5aafc2f6f1e5b108cb6be947" +} +``` + +**Save a worldpay receiving account.** /payment-instruments/worldpay-merchants + +Code 201 + +Response body + +```json +{ + "key": "926db588-d800-496f-85ce-0c2c4a203665", + "ID": "5aafc1e7f1e5b108cb6be943" +} +``` + +**Pay using stored card.** /payment-instruments/cards/{instrumentID}/payments + +Code 200 + +Response body + +```json +{ + "transaction": { + "id": "09f16a90-4328-4625-85b9-995a69ae24b4" + } +} +``` \ No newline at end of file diff --git a/work/Comcarde/tasks/commit-template.md b/work/Comcarde/tasks/commit-template.md new file mode 100644 index 0000000..1e9bc1d --- /dev/null +++ b/work/Comcarde/tasks/commit-template.md @@ -0,0 +1,14 @@ +BRIDGE-###: Subject line (<50 chars) + +# Summary + +Summary of changes. "Why" more than "what". + +# Details + +Any additional details. Specific technical points, etc. + +# Test Plan + +* Unit tests run and pass +* Additional manual tests (check error messages, integration etc.) \ No newline at end of file