Test harness cleanup. Moving kqed:source assignment to plug-inable location

This commit is contained in:
Kip Gebhardt 2015-01-27 16:09:39 -08:00
parent 72da470d3b
commit 9066644250
4 changed files with 8 additions and 9 deletions

View File

@ -87,9 +87,9 @@ RssBraider.prototype.processFeed = function(feed_name, format, callback)
item; item;
while ( item = stream.read() ) { while ( item = stream.read() ) {
// logger.info("item received", item.guid); if (source.url) {
// Set kqed source item.source_url = source.url;
item["kqed:source"] = source.url; }
var article = self.processItem(item); var article = self.processItem(item);
if (article) { if (article) {
source_articles.push(article); source_articles.push(article);
@ -174,9 +174,9 @@ RssBraider.prototype.processItem = function (item) {
////////////////// //////////////////
// kqed source // kqed source
if (item['kqed:source']) { if (item.source_url) {
itemOptions.custom_elements.push( itemOptions.custom_elements.push(
{ 'kqed:source': item['kqed:source'] } { 'kqed:source': item.source_url }
); );
} }
@ -259,6 +259,7 @@ RssBraider.prototype.dedupe = function(articles_arr){
return _.uniq(articles_arr); return _.uniq(articles_arr);
}; };
// Could be a plugin
RssBraider.prototype.date_sort = function(articles_arr) { RssBraider.prototype.date_sort = function(articles_arr) {
var sorted_articles = _.sortBy(articles_arr, function(article) { var sorted_articles = _.sortBy(articles_arr, function(article) {
return article.date.getTime(); return article.date.getTime();

View File

@ -21,9 +21,8 @@
"include-folder": "^0.7.0", "include-folder": "^0.7.0",
"lodash": "^2.4.1", "lodash": "^2.4.1",
"mockdate": "^1.0.1", "mockdate": "^1.0.1",
"prova": "^2.1.1",
"request": "^2.51.0", "request": "^2.51.0",
"rss": "git://github.com/rv-kip/node-rss.git#603b25", "rss": "git://github.com/rv-kip/node-rss.git#603b25",
"tape": "^3.0.3" "tape": "^3.0.3"
} }
} }

View File

@ -1,6 +1,6 @@
// prova is a wrapper for tape // prova is a wrapper for tape
// use npm run test:browser to run tests in a browser // use npm run test:browser to run tests in a browser
var test = require('prova'), var test = require('tape'),
RssBraider = require('../index'), RssBraider = require('../index'),
includeFolder = require('include-folder'), includeFolder = require('include-folder'),
expectedOutput = includeFolder(__dirname + '/expected_output', /.*\.xml$/); expectedOutput = includeFolder(__dirname + '/expected_output', /.*\.xml$/);

View File

@ -20,7 +20,6 @@ var feed = {
"name" : "sample_feed", "name" : "sample_feed",
"count" : 1, "count" : 1,
"file_path" : __dirname + "/sample_feed.xml", "file_path" : __dirname + "/sample_feed.xml",
"categories" : ['something can go here']
}, },
] ]