martin/nci
1
0
Fork 0
mirror of https://gitlab.silvrtree.co.uk/martind2000/nci.git synced 2025-02-19 02:49:15 +00:00
Code Issues Projects Releases Wiki Activity

call callback once

Browse Source
This commit is contained in:
oleg 2014-12-04 23:22:14 +03:00
parent bdce719b4e
commit 26cb2aa9a1
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/command/spawn.js
View File

@ -2,7 +2,8 @@
var spawn = require('child_process').spawn, var spawn = require('child_process').spawn,
ParentCommand = require('./base').Command, ParentCommand = require('./base').Command,
inherits = require('util').inherits; inherits = require('util').inherits,
utils = require('../utils');
function Command(params) { function Command(params) {
params = params || {}; params = params || {};
@ -22,6 +23,7 @@ Command.prototype.run = function(params, callback) {
stdout = ''; stdout = '';
if (!params.cmd) return callback(new Error('`cmd` is not set')); if (!params.cmd) return callback(new Error('`cmd` is not set'));
if (!params.args) return callback(new Error('`args` is not set')); if (!params.args) return callback(new Error('`args` is not set'));
callback = utils.once(callback);
params.options = params.options || {}; params.options = params.options || {};
params.options.cwd = params.options.cwd || this.cwd; params.options.cwd = params.options.cwd || this.cwd;
var cmd = spawn(params.cmd, params.args, params.options); var cmd = spawn(params.cmd, params.args, params.options);
@ -34,7 +36,6 @@ Command.prototype.run = function(params, callback) {
callback(new Error('Spawned command outputs to stderr: ' + data)); callback(new Error('Spawned command outputs to stderr: ' + data));
cmd.kill(); cmd.kill();
}); });
// TODO; callback should be called only once (port once from underscore)
cmd.on('close', function(code) { cmd.on('close', function(code) {
var err = null; var err = null;
if (code !== 0) err = new Error( if (code !== 0) err = new Error(

9
lib/utils.js
View File

@ -13,3 +13,12 @@ exports.isObject = function(obj) {
exports.noop = function() {}; exports.noop = function() {};
exports.slice = Array.prototype.slice; exports.slice = Array.prototype.slice;
exports.once = function(func) {
var isCalled = false;
return function() {
if (isCalled) return;
func.apply(this, arguments);
isCalled = true;
};
};