From 99654fdc1d5e8cc72d7345bce66fc74971d36d86 Mon Sep 17 00:00:00 2001 From: martin Date: Wed, 16 May 2018 11:02:44 +0100 Subject: [PATCH] 2018-05-16 --- log.md | 34 +++++++++++++++ tasks/bridge-1027/check-in-2.md | 76 ++++++++++++++++++++++++++++++++ tasks/bridge-1027/check-in.md | 0 tasks/bridge-1027/recreate.md | 0 tasks/bridge-1027/what.md | 0 tasks/bridge-923/commit-msg.md | 0 tasks/bridge-923/rules.md | 31 +++++++++++++ tasks/bridge-923/what.md | 0 tasks/bridge-970/commit.md | 41 ++++++++++++++++++ tasks/bridge-970/process.md | 77 +++++++++++++++++++++++++++++++++ 10 files changed, 259 insertions(+) create mode 100644 tasks/bridge-1027/check-in-2.md create mode 100644 tasks/bridge-1027/check-in.md create mode 100644 tasks/bridge-1027/recreate.md create mode 100644 tasks/bridge-1027/what.md create mode 100644 tasks/bridge-923/commit-msg.md create mode 100644 tasks/bridge-923/rules.md create mode 100644 tasks/bridge-923/what.md create mode 100644 tasks/bridge-970/commit.md create mode 100644 tasks/bridge-970/process.md diff --git a/log.md b/log.md index 40d3267..09762ae 100644 --- a/log.md +++ b/log.md @@ -222,4 +222,38 @@ BRIDGE-1001 - processorResponse inconsistent location Started BRIDGE-923 - Implementation +Started BRIDGE-1027 processorResponse not being populated on error +--- + +##### 2018-05-07 // Monday ##### + +*DONE* BRIDGE-1027 processorResponse not being populated on error + +##### 2018-05-08 // Tuesday ##### + +Started BRIDGE-923 - Implementation + +##### 2018-05-09 // Wednesday ##### + +BRIDGE-923 - Implementation + +##### 2018-05-10 // Thursday ##### + +Commited BRIDGE-923 - Implementation + +##### 2018-05-11 // Friday ##### + +Holiday + +--- + +##### 2018-05-15 // Monday ##### + +Holiday + +##### 2018-05-16 // Tuesday ##### + +Started BRIDGE-970 - E2E Swagger tests + +##### 2018-05-17 // Wednesday ##### \ No newline at end of file diff --git a/tasks/bridge-1027/check-in-2.md b/tasks/bridge-1027/check-in-2.md new file mode 100644 index 0000000..84b48f1 --- /dev/null +++ b/tasks/bridge-1027/check-in-2.md @@ -0,0 +1,76 @@ +BRIDGE-1027 processorResponse not being populated on error + +# Summary + +Updating `list-atps-testcases.js` to allow a test of processorResponse + +Added to `get-all-atps-for-rtp.spec.js` and it is also called in `list-atps-testcases.js`, and in a number of other tests. + +# Test Plan + +* Run All tests +* Run E2E: get All ATPs +* E2E: list ATPs for receivable RTP PASSED + +Test Results + +``` +E2E: get All ATPs PASSED + ObjectID tests PASSED + ✓ Test with a valid objectID PASSED + ✓ Test objectID with an invalid pattern PASSED + ✓ Test objectID is too short PASSED + ✓ Test objectID is too long PASSED + + Invalid path PASSED + ✓ Test responds with 404 PASSED + ✓ Test responds with error PASSED + + Unauthorised access PASSED + ✓ Test responds with error PASSED + + Tests the response PASSED + Response validation for 200 Get response PASSED + Accepts a `data` array with an ATP that PASSED + ✓ Test maps CARD payment which SUCCEEDS PASSED + ✓ Test maps CARD payment which FAILS_PAYMENT_PROCESSOR PASSED + ✓ Test maps CARD payment which FAILS_NO_RTP PASSED + ✓ Test maps CARD payment which FAILS_PAYMENT_BAD_REQUEST PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which SUCCEEDS PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which FAILS_PAYMENT_PROCESSOR PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which FAILS_PAYMENT_BAD_REQUEST PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which SUCCEEDS PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which FAILS_NO_INSTRUMENT PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which FAILS_NO_RTP PASSED + + ✓ Test rejects a response with processorResponse in errorDetails PASSED + ✓ Test rejects an empty response PASSED + +19 Of 19 Passing + + +E2E: list ATPs for receivable RTP PASSED + Response validation for 200 OK responses PASSED + Accepts a `data` array with an ATP that PASSED + ✓ Test maps CARD payment which SUCCEEDS PASSED + ✓ Test maps CARD payment which FAILS_PAYMENT_PROCESSOR PASSED + ✓ Test maps CARD payment which FAILS_NO_RTP PASSED + ✓ Test maps CARD payment which FAILS_PAYMENT_BAD_REQUEST PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which SUCCEEDS PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which FAILS_PAYMENT_PROCESSOR PASSED + ✓ Test maps STORED_INSTRUMENT_FOUND payment which FAILS_PAYMENT_BAD_REQUEST PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which SUCCEEDS PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which FAILS_NO_INSTRUMENT PASSED + ✓ Test maps STORED_INSTRUMENT_NOT_FOUND payment which FAILS_NO_RTP PASSED + + ✓ Test accepts a response with an empty `data` array PASSED + ✓ Test rejects a response missing the `data` property PASSED + ✓ Test rejects a response with any extra properties PASSED + + ✓ Test rejects objectID with an invalid pattern PASSED + ✓ Test rejects objectID if too short PASSED + ✓ Test rejects objectID if too long PASSED + +16 Of 16 Passing + +``` \ No newline at end of file diff --git a/tasks/bridge-1027/check-in.md b/tasks/bridge-1027/check-in.md new file mode 100644 index 0000000..e69de29 diff --git a/tasks/bridge-1027/recreate.md b/tasks/bridge-1027/recreate.md new file mode 100644 index 0000000..e69de29 diff --git a/tasks/bridge-1027/what.md b/tasks/bridge-1027/what.md new file mode 100644 index 0000000..e69de29 diff --git a/tasks/bridge-923/commit-msg.md b/tasks/bridge-923/commit-msg.md new file mode 100644 index 0000000..e69de29 diff --git a/tasks/bridge-923/rules.md b/tasks/bridge-923/rules.md new file mode 100644 index 0000000..03084c5 --- /dev/null +++ b/tasks/bridge-923/rules.md @@ -0,0 +1,31 @@ +{ + "trigger": { + "stage": "paymentComplete", + "type": "ruleIdInRtp" + }, + "rules": [ + { + "paymentInstrument": { + "encryptionKey": "1f88fcb2-aa11-443e-a794-8d30563df6a3", + "CV2": "000" + }, + "payeeID": "5af1b91a5c980358d227384f", + "percentageShare": 1 + } + ] +} + + +should return + +{ + "ID": "00000000-0000-0000-0000-000000000000" +} + + + + +{ + "cardUsageKey": "1f88fcb2-aa11-443e-a794-8d30563df6a3", + "cardID": "5af1b91a5c980358d227384f" +} \ No newline at end of file diff --git a/tasks/bridge-923/what.md b/tasks/bridge-923/what.md new file mode 100644 index 0000000..e69de29 diff --git a/tasks/bridge-970/commit.md b/tasks/bridge-970/commit.md new file mode 100644 index 0000000..ecef52b --- /dev/null +++ b/tasks/bridge-970/commit.md @@ -0,0 +1,41 @@ +BRIDGE-970 E2E Swagger tests + +# Summary + +* Created `dev_api/specs/confirm-activate-rule.e2e.spec.js` +* Updated `rules_controller.js` with stub `confirmReceivableRule` + +# Test Plan + +* Run All tests +* Run E2E: Confirm a rule + +Test Results + +``` +E2E: Confirm a rule PASSED + Good parameter data tests PASSED + ✓ Test with a full set of correct parameters PASSED + + Tests body with missing & incorrect required parameters PASSED + Missing body contents PASSED + ✓ Test with no payer instrument ID parameter PASSED + ✓ Test with no payer instrument key parameter PASSED + + Incorrect body contents PASSED + ✓ Test with Invalid Object ID parameter PASSED + ✓ Test with Too Short ID parameter PASSED + ✓ Test with Too Long ID parameter PASSED + ✓ Test with Invalid instrument key parameter PASSED + ✓ Test with Short instrument key parameter PASSED + ✓ Test with Long instrument key parameter PASSED + + Tests path incorrect ObjectID parameters PASSED + Incorrect path ObjectID contents PASSED + ✓ Test with Invalid Object ID parameter PASSED + ✓ Test with Too Short Object ID parameter PASSED + ✓ Test with Too Long Object ID parameter PASSED + +12 Of 12 Passing + +``` \ No newline at end of file diff --git a/tasks/bridge-970/process.md b/tasks/bridge-970/process.md new file mode 100644 index 0000000..e6ef162 --- /dev/null +++ b/tasks/bridge-970/process.md @@ -0,0 +1,77 @@ +Re-authorise with : + +``` +Bearer YTM2ZGQ1NzUtOWFmNS01MjMyLTg5MjYtM2NkZjA5ZDU2ZGU1 + +``` + +## step 1 ## + +Payee Account? +``` + +{ + "description": "Silver Carpenter Inc. account.", + "receivingAccountServiceKey": "T_S_7c8551db-2aa0-489d-b80e-d1a8d42e4bfb" +} + +``` + + +created world pay + +{ + "key": "46112bc2-ea45-4c1e-afbd-90d82dd7da4c", + "ID": "5afaeb90297d4a0c895bb440" +} + + +created credit card + +{ + "cardUsageKey": "55f3fc0a-0d6f-485d-886b-9b8984a92923", + "cardID": "5afaec04297d4a0c895bb444" +} + + + + +create a new rule +const goodRuleParams = { + trigger: { + stage: 'paymentComplete', + type: 'ruleIdInRtp' + }, + rule: { + payerInstrument: { + key: "55f3fc0a-0d6f-485d-886b-9b8984a92923", + ID: "5afaec04297d4a0c895bb444" + }, + payeeID: '5afaeb90297d4a0c895bb440', + percentageShare: 1 + } +}; + + +{ + "trigger": { + "stage": "paymentComplete", + "type": "ruleIdInRtp" + }, + "rule": { + "payerInstrument": { + "ID": "5afaec04297d4a0c895bb444", + "key": "55f3fc0a-0d6f-485d-886b-9b8984a92923" + }, + "payeeID": "5afaeb90297d4a0c895bb440", + "percentageShare": 2 + } +} + + +created rule id + +{ + "ID": "5afaec7e297d4a0c895bb448" +} +