From 93b4ca8820751e99ee5a1991bb0d5adc0116f6a8 Mon Sep 17 00:00:00 2001
From: martin <martin@comcarde.com>
Date: Tue, 22 May 2018 13:55:10 +0100
Subject: [PATCH] 2018-05-22 B

---
 log.md                      |  4 ++-
 tasks/bridge-1162/byhand.md | 31 ++++++++++++++++++++
 tasks/bridge-1162/commit.md | 10 +++++++
 tasks/bridge-1163/commit.md | 58 +++++++++++++++++++++++++++++++++++++
 4 files changed, 102 insertions(+), 1 deletion(-)

diff --git a/log.md b/log.md
index 1579ea1..3759c05 100644
--- a/log.md
+++ b/log.md
@@ -284,4 +284,6 @@ Started BRIDGE-1163 - Add description to rule
 
 ##### 2018-05-22 // Tuesday #####
 
-*DONE* BRIDGE-1162 - metaData appears to be RulesTriggerData
\ No newline at end of file
+*DONE* BRIDGE-1162 - metaData appears to be RulesTriggerData
+
+*DONE* BRIDGE-1163 - Add description to rule
\ No newline at end of file
diff --git a/tasks/bridge-1162/byhand.md b/tasks/bridge-1162/byhand.md
index e69de29..badd5a5 100644
--- a/tasks/bridge-1162/byhand.md
+++ b/tasks/bridge-1162/byhand.md
@@ -0,0 +1,31 @@
+```
+Bearer YTM2ZGQ1NzUtOWFmNS01MjMyLTg5MjYtM2NkZjA5ZDU2ZGU1
+
+```
+
+Payee Account
+```
+
+{
+  "description": "Silver Carpenter Inc. account.",
+  "receivingAccountServiceKey": "T_S_7c8551db-2aa0-489d-b80e-d1a8d42e4bfb"
+}
+
+```
+
+response:
+
+{
+  "key": "96ecc2d0-750d-452d-980b-2518cd5a34e0",
+  "ID": "5afd9e0d9043d33a97cbbf95"
+}
+
+
+
+credit card;
+
+{
+  "cardUsageKey": "69de2ccb-8e8d-421f-972d-86209d4862cc",
+  "cardID": "5afd9e329043d33a97cbbf99"
+}
+
diff --git a/tasks/bridge-1162/commit.md b/tasks/bridge-1162/commit.md
index e69de29..1719ba7 100644
--- a/tasks/bridge-1162/commit.md
+++ b/tasks/bridge-1162/commit.md
@@ -0,0 +1,10 @@
+BRIDGE-1163 - Rename rulesTriggerData to metaData
+
+# Summary
+
+* Replace all instances of metaData with metadata
+* Replace all instances of MetaData with Metadata
+
+# Test Plan
+
+* Run All tests
diff --git a/tasks/bridge-1163/commit.md b/tasks/bridge-1163/commit.md
index e69de29..aef8c96 100644
--- a/tasks/bridge-1163/commit.md
+++ b/tasks/bridge-1163/commit.md
@@ -0,0 +1,58 @@
+BRIDGE-1163 - Add description to rule
+
+# Summary
+
+* An orderDescription field was added to single-rule-create in Swagger.
+* Marked payerInstrument and payeeID as required fields in single-rule-create
+* Updated /specs/create-rule.e2e.spec.js to test for orderDescription & missing payerInstrument and payeeID
+
+# Test Plan
+
+* Run All tests
+* Run E2E: Create a rule
+
+```
+E2E: Create a rule PASSED
+    Tests the body PASSED
+        Tests with missing required parameters PASSED
+            
+            Missing paymentInstrument contents PASSED
+                ✓ Test with no payer instrument ID parameter PASSED
+                ✓ Test with no payer instrument key parameter PASSED
+
+            Missing Trigger PASSED
+                ✓ Test with no Trigger parameter PASSED
+                
+            Missing Payment rules PASSED
+                ✓ Test with no Payment rules parameter PASSED
+            
+            Missing Rule parameters PASSED
+                ✓ Test with no rule payerInstrument parameter PASSED
+                ✓ Test with no rule payeeID parameter PASSED
+
+    Bad data tests PASSED
+        ✓ Test with a badly formatted rule payer instrument ID parameter PASSED
+        ✓ Test with a badly formatted rule payer key parameter PASSED
+        ✓ Test with a badly formatted rule payeeID parameter PASSED
+        ✓ Test with a short rule payeeID parameter PASSED
+        ✓ Test with a long rule payeeID parameter PASSED
+        ✓ Test with a badly formatted rule percentageShare parameter PASSED
+        ✓ Test with a out of range rule percentageShare parameter PASSED
+        ✓ Test with a badly formatted Trigger Stage parameter PASSED
+        ✓ Test with a badly formatted Trigger Type parameter PASSED
+        ✓ Test with a long rule description parameter PASSED
+
+    Good parameter data tests PASSED
+        ✓ Test with a full set of correct parameters PASSED
+
+    Authorization PASSED
+        ✓ Test rejects invalid bearer token PASSED
+
+    Tests the response PASSED
+        Response validation for 201 Created responses PASSED
+            ✓ Test returns a response with `valid` ID PASSED
+            ✓ Test rejects a response with `invalid` ID PASSED
+            ✓ Test rejects an empty response PASSED
+            
+21 Of 21 Passing
+```