Update CHANGELOG.md

* Create check-metadata.yml

* Update check-metadata.yml

* Update check-metadata.yml

* Update check-metadata.yml

* Update .github/workflows/check-metadata.yml

Co-authored-by: Sébastiaan <se_bastiaan@outlook.com>

* Update .github/workflows/check-metadata.yml

Co-authored-by: Sébastiaan <se_bastiaan@outlook.com>

---------

Co-authored-by: Sébastiaan <se_bastiaan@outlook.com>

.github/workflows/check-metadata.yml

@@ -0,0 +1,55 @@
+name: Check Metadata
+on:
+  pull_request:
+    paths:
+      - '/ct/*.sh'
+      - '/install/*.sh'
+jobs:
+  check-metadata:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+      - name: Check Metadata Lines in Scripts
+        shell: bash
+        run: |
+          set -e
+          ERROR_COUNT=0
+          FILES=$(find . -name "*.sh")
+
+          for FILE in $FILES; do
+            if [[ "$(sed -n '3p' "$FILE")" == "# Copyright (c) 2021-2024 community-scripts ORG" ]]; then
+                echo "Check for Copyright metadata passed for line 3 in: $FILE"
+            else
+                echo "Error in $FILE: Copyright metadata missing or not on line 3"
+                ERROR_COUNT=$((ERROR_COUNT + 1))
+            fi
+            
+            if sed -n '4p' "$FILE" | grep -qE "^# Author: .+"; then
+                echo "Check for Author metadata passed for line 4 in: $FILE"
+            else
+                echo "Error in $FILE: Author metadata missing or invalid on line 4"
+                ERROR_COUNT=$((ERROR_COUNT + 1))
+            fi
+
+            if [[ "$(sed -n '5p' "$FILE")" == "# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE" ]]; then
+                echo "Check for License metadata passed for line 5 in: $FILE"
+            else
+                echo "Error in $FILE: License metadata missing or not on line 5"
+                ERROR_COUNT=$((ERROR_COUNT + 1))
+            fi
+
+            if sed -n '6p' "$FILE" | grep -qE "^# Source: .+"; then
+                echo "Check for Source metadata passed for line 6 in: $FILE"
+            else
+                echo "Error in $FILE: Source metadata missing or invalid on line 6"
+                ERROR_COUNT=$((ERROR_COUNT + 1))
+            fi
+          done
+
+          if [[ "$ERROR_COUNT" -gt 0 ]]; then
+              echo "$ERROR_COUNT script(s) failed validation."
+              exit 1
+          else
+              echo "All scripts passed."
+          fi

CHANGELOG.md

@@ -16,6 +16,26 @@ All LXC instances created using this repository come pre-installed with Midnight
 > [!IMPORTANT]
 Do not break established syntax in this file, as it is automatically updated by a Github Workflow
 
+## 2025-01-03
+
+### Changed
+
+### 🚀 Updated Scripts
+
+- Improve Homarr Installation [@MickLesk](https://github.com/MickLesk) ([#1208](https://github.com/community-scripts/ProxmoxVE/pull/1208))
+- Fix: Zabbix-Update Script [@MickLesk](https://github.com/MickLesk) ([#1205](https://github.com/community-scripts/ProxmoxVE/pull/1205))
+- Update Script: Lazylibrarian [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1190](https://github.com/community-scripts/ProxmoxVE/pull/1190))
+- Fix: Memos update function [@MickLesk](https://github.com/MickLesk) ([#1207](https://github.com/community-scripts/ProxmoxVE/pull/1207))
+- Keep Lubelogger data after update to a new version [@JcMinarro](https://github.com/JcMinarro) ([#1200](https://github.com/community-scripts/ProxmoxVE/pull/1200))
+
+### 🌐 Website
+
+- Update Nextcloud-LXC JSON [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1191](https://github.com/community-scripts/ProxmoxVE/pull/1191))
+
+### 🧰 Maintenance
+
+- Github action to check metadata lines in scripts. [@quantumryuu](https://github.com/quantumryuu) ([#1110](https://github.com/community-scripts/ProxmoxVE/pull/1110))
+
 ## 2025-01-02
 
 ### Changed

ct/lubelogger.sh

@@ -42,11 +42,19 @@ function update_script() {
     msg_info "Updating ${APP} to v${RELEASE}"
     cd /opt
     wget -q https://github.com/hargata/lubelog/releases/download/v${RELEASE}/LubeLogger_v${RELEASE_TRIMMED}_linux_x64.zip
-    cp /opt/lubelogger/appsettings.json /opt/appsettings.json
+    mkdir -p /tmp/lubeloggerData/wwwroot
+    cp /opt/lubelogger/appsettings.json /tmp/lubeloggerData/appsettings.json
+    cp -r /opt/lubelogger/config /tmp/lubeloggerData/
+    cp -r /opt/lubelogger/data /tmp/lubeloggerData/
+    [[ -e /opt/lubelogger/wwwroot/translations ]] && cp -r /opt/lubelogger/wwwroot/translations /tmp/lubeloggerData/wwwroot/
+    [[ -e /opt/lubelogger/wwwroot/documents ]] && cp -r /opt/lubelogger/wwwroot/documents /tmp/lubeloggerData/wwwroot/
+    [[ -e /opt/lubelogger/wwwroot/images ]] && cp -r /opt/lubelogger/wwwroot/images /tmp/lubeloggerData/wwwroot/
+    [[ -e /opt/lubelogger/wwwroot/temp ]] && cp -r /opt/lubelogger/wwwroot/temp /tmp/lubeloggerData/wwwroot/
+    [[ -e /opt/lubelogger/log ]] && cp -r /opt/lubelogger/log /tmp/lubeloggerData/
     rm -rf /opt/lubelogger
     unzip -qq LubeLogger_v${RELEASE_TRIMMED}_linux_x64.zip -d lubelogger
     chmod 700 /opt/lubelogger/CarCareTracker
-    mv -f /opt/appsettings.json /opt/lubelogger/appsettings.json
+    cp -rf /tmp/lubeloggerData/* /opt/lubelogger/
     echo "${RELEASE}" >"/opt/${APP}_version.txt"
     msg_ok "Updated ${APP} to v${RELEASE}"
 
@@ -56,6 +64,7 @@ function update_script() {
 
     msg_info "Cleaning up"
     rm -rf /opt/LubeLogger_v${RELEASE_TRIMMED}_linux_x64.zip
+    rm -rf /tmp/lubeloggerData
     msg_ok "Cleaned"
     msg_ok "Updated Successfully"
   else

ct/memos.sh

@@ -34,6 +34,7 @@ function update_script() {
   fi
   msg_info "Updating $APP (Patience)"
   cd /opt/memos
+  git reset --hard HEAD
   output=$(git pull --no-rebase)
   if echo "$output" | grep -q "Already up to date."; then
     msg_ok "$APP is already up to date."

ct/zabbix.sh

@@ -41,7 +41,7 @@ function update_script() {
     cp /etc/zabbix/zabbix_server.conf /opt/zabbix-backup/
     cp /etc/apache2/conf-enabled/zabbix.conf /opt/zabbix-backup/
     cp -R /usr/share/zabbix/ /opt/zabbix-backup/
-    cp -R /usr/share/zabbix-* /opt/zabbix-backup/
+    #cp -R /usr/share/zabbix-* /opt/zabbix-backup/ Remove temporary
     rm -Rf /etc/apt/sources.list.d/zabbix.list
     cd /tmp
     wget -q https://repo.zabbix.com/zabbix/7.2/release/debian/pool/main/z/zabbix-release/zabbix-release_latest+debian12_all.deb

install/5etools-install.sh

@@ -24,23 +24,23 @@ $STD apt-get install -y \
 msg_ok "Installed Dependencies"
 
 # Setup App
-msg_info "Set up base 5etools"
+msg_info "Set up 5etools Base"
 RELEASE=$(curl -s https://api.github.com/repos/5etools-mirror-3/5etools-src/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
 wget -q "https://github.com/5etools-mirror-3/5etools-src/archive/refs/tags/${RELEASE}.zip"
 unzip -q "${RELEASE}.zip"
 mv "5etools-src-${RELEASE:1}" /opt/5etools
 echo "${RELEASE}" >"/opt/5etools_version.txt"
 rm "${RELEASE}.zip"
-msg_ok "Set up base 5etools"
+msg_ok "Set up 5etools Base"
 
-msg_info "Set up 5etools images"
+msg_info "Set up 5etools Image"
 IMG_RELEASE=$(curl -s https://api.github.com/repos/5etools-mirror-2/5etools-img/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
 curl -sSL "https://github.com/5etools-mirror-2/5etools-img/archive/refs/tags/${IMG_RELEASE}.zip" > "${IMG_RELEASE}.zip"
 unzip -q "${IMG_RELEASE}.zip"
 mv "5etools-img-${IMG_RELEASE:1}" /opt/5etools/img
 echo "${IMG_RELEASE}" >"/opt/5etools_IMG_version.txt"
 rm "${IMG_RELEASE}.zip"
-msg_ok "Set up 5etools images"
+msg_ok "Set up 5etools Image"
 
 msg_info "Creating Service"
 cat <<EOF >> /etc/apache2/apache2.conf
@@ -52,12 +52,10 @@ cat <<EOF >> /etc/apache2/apache2.conf
 EOF
 rm -rf /var/www/html
 ln -s "/opt/5etools" /var/www/html
-
 chown -R www-data: "/opt/5etools"
 chmod -R 755 "/opt/5etools"
-apache2ctl start
-msg_ok "Creating Service"
-# Cleanup
+msg_ok "Created Service"
+
 msg_info "Cleaning up"
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean

install/homarr-install.sh

@@ -16,11 +16,14 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y curl
-$STD apt-get install -y sudo
-$STD apt-get install -y mc
-$STD apt-get install -y ca-certificates
-$STD apt-get install -y gnupg
+$STD apt-get install -y \
+  sudo \
+  mc \
+  ca-certificates \
+  gnupg \
+  make \
+  g++ \
+  build-essentials
 msg_ok "Installed Dependencies"
 
 msg_info "Setting up Node.js Repository"

install/lazylibrarian-install.sh

@@ -15,15 +15,21 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y curl
-$STD apt-get install -y sudo
-$STD apt-get install -y mc
-$STD apt-get install -y git
+$STD apt-get install -y \
+    curl \
+    sudo \
+    mc \
+    git \
+    libpng-dev \
+    libjpeg-dev \
+    libtiff-dev \
+    imagemagick
 msg_ok "Installed Dependencies"
 
 msg_info "Installing Python3 Dependencies"
-$STD apt-get install -y pip
-$STD apt-get install -y python3-irc
+$STD apt-get install -y \
+    pip \
+    python3-irc
 $STD pip install jaraco.stream
 $STD pip install python-Levenshtein
 $STD pip install soupsieve
@@ -31,6 +37,8 @@ msg_ok "Installed Python3 Dependencies"
 
 msg_info "Installing LazyLibrarian"
 $STD git clone https://gitlab.com/LazyLibrarian/LazyLibrarian /opt/LazyLibrarian
+cd /opt/LazyLibrarian
+$STD pip install .
 msg_ok "Installed LazyLibrarian"
 
 msg_info "Creating Service"

install/pf2etools-install.sh

@@ -42,11 +42,10 @@ cat <<EOF >> /etc/apache2/apache2.conf
 EOF
 rm -rf /var/www/html
 ln -s "/opt/Pf2eTools" /var/www/html
-
 chown -R www-data: "/opt/Pf2eTools"
 chmod -R 755 "/opt/Pf2eTools"
-apache2ctl start
-msg_ok "Creating Service"
+msg_ok "Created Service"
+
 # Cleanup
 msg_info "Cleaning up"
 rm "${RELEASE}.zip"

json/nextcloudpi.json

@@ -41,5 +41,10 @@
         "username": null,
         "password": null
     },
-    "notes": []
+    "notes": [
+        {
+            "text": "Only Alpine: To get the username and password, run the script again inside the LXC shell.",
+            "type": "warning"
+        }
+    ]
 }

json/pf2etools.json

@@ -16,7 +16,7 @@
     "install_methods": [
         {
             "type": "default",
-            "script": "ct/Pf2eTools.sh",
+            "script": "ct/pf2etools.sh",
             "resources": {
                 "cpu": 1,
                 "ram": 512,