Hotfix build.func: Error when tags are empty (#1492)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

.github/workflows/App_Header_Merge_Into_main.yaml

@@ -1,66 +0,0 @@
-name: Auto Update .app-headers and Create PR
-
-on:
-  push:
-    branches:
-      - main
-    paths:
-      - 'ct/**.sh'
-
-jobs:
-  update-app-headers:
-    runs-on: ubuntu-latest
-    steps:
-      # Step 1: Checkout the repository
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      # Step 2: Set up Git user for committing changes
-      - name: Set up Git
-        run: |
-          git config --global user.name "GitHub Actions"
-          git config --global user.email "actions@github.com"
-
-      # Step 3: Ensure .app-headers file exists
-      - name: Ensure .app-headers file exists
-        run: |
-          if [ ! -f ct/.app-headers ]; then
-            echo "Creating .app-headers file."
-            touch ct/.app-headers
-          fi
-
-      # Step 4: Process the ct/*.sh files and update .app-headers
-      - name: Update .app-headers with figlet output
-        run: |
-          echo "Updating .app-headers with figlet output."
-          for script in ct/*.sh; do
-            if grep -q 'APP=' "$script"; then
-              APP_NAME=$(grep -oP 'APP=\K\w+' "$script")
-              echo "Processing $script for APP: \"$APP_NAME\""
-              figlet "$APP_NAME" >> ct/.app-headers
-            fi
-          done
-
-      # Step 5: Check out and merge main into the update-app-headers branch without committing
-      - name: Merge main into update-app-headers
-        run: |
-          git fetch origin
-          git checkout update-app-headers
-          git merge origin/main --no-ff --no-commit -m "Merge main into update-app-headers"
-          echo "Merge complete. Please review and commit the changes manually."
-
-      # Step 6: Check if a PR exists and create one if it doesn't
-      - name: Create Pull Request if not exists
-        run: |
-          PR_EXISTS=$(gh pr list --head "update-app-headers" --json number --jq '.[].number')
-
-          if [ -z "$PR_EXISTS" ]; then
-            echo "Creating a new PR."
-            PR_URL=$(gh pr create --title "[core]: update .app-headers to latest version" \
-                                   --body "This PR automatically updates the .app-headers file." \
-                                   --head update-app-headers \
-                                   --base main)
-            echo "PR created: $PR_URL"
-          else
-            echo "PR already exists."
-          fi

.github/workflows/App_Header_Merge_update .app-headers_in_update-app-headers

@@ -1,34 +0,0 @@
-name: Update .app-headers with figlet output
-
-on:
-  workflow_run:
-    workflows: ["Merge main into update-app-headers"]
-    types:
-      - completed
-
-jobs:
-  update-app-headers:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Ensure .app-headers file exists silently
-        run: |
-          if [ ! -f ct/.app-headers ]; then
-            touch ct/.app-headers
-          fi
-
-      - name: Update .app-headers with figlet output silently
-        run: |
-          for script in ct/*.sh; do
-            if grep -q 'APP=' "$script"; then
-              APP_NAME=$(grep -oP 'APP=\K\w+' "$script")
-              if [ ! -z "$APP_NAME" ]; then
-                echo "Adding $APP_NAME to .app-headers"
-                figlet "$APP_NAME" >> ct/.app-headers 2>/dev/null || echo "figlet failed for $APP_NAME"
-              fi
-            fi
-          done
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/auto-update-app-headers.yml

@@ -0,0 +1,82 @@
+name: Auto Update .app-headers
+
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - 'ct/**.sh'
+  workflow_dispatch:  # Ermöglicht das manuelle Ausführen der Action
+
+jobs:
+  update-app-headers:
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: write
+      pull-requests: write
+
+    steps:
+      # Step 1: Checkout repository
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      # Step 2: Set up Git user for committing changes
+      - name: Set up Git
+        run: |
+          git config --global user.name "GitHub Actions"
+          git config --global user.email "actions@github.com"
+
+      # Step 3: Install figlet
+      - name: Install figlet
+        run: sudo apt-get install -y figlet
+
+      # Step 4: Run the generate-app-headers.sh script to update .app-headers
+      - name: Run generate-app-headers.sh to update .app-headers
+        run: |
+          chmod +x .github/workflows/generate-app-headers.sh
+          .github/workflows/generate-app-headers.sh
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      # Step 5: Check if there are any changes
+      - name: Check if there are any changes
+        id: verify-diff
+        run: |
+          git diff --quiet . || echo "changed=true" >> $GITHUB_OUTPUT
+
+      # Step 6: Commit changes (if any) and create a PR
+      - name: Commit and create PR if changes exist
+        if: steps.verify-diff.outputs.changed == 'true'
+        run: |
+          git config --global user.name "github-actions[bot]"
+          git config --global user.email "github-actions[bot]@users.noreply.github.com"
+          git add ./misc/.app-headers
+          git commit -m "Update .app-headers file"
+          # Create a temporary branch for the PR
+          git checkout -b pr-update-app-headers
+          git push origin pr-update-app-headers --force
+          
+          # Create PR against main
+          gh pr create --title "[core] update .app-headers file" \
+                       --body "This PR is auto-generated by a Github Action to update the .app-headers file." \
+                       --head pr-update-app-headers \
+                       --base main \
+                       --label "automated pr"
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Re-approve pull request after update
+        if: steps.verify-diff.outputs.changed == 'true'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          PR_NUMBER=$(gh pr list --head "pr-update-app-headers" --json number --jq '.[].number')
+          # Check if the PR was created by the bot (skip review if so)
+          PR_AUTHOR=$(gh pr view "$PR_NUMBER" --json author --jq '.author.login')
+          if [ "$PR_AUTHOR" != "github-actions[bot]" ]; then
+            gh pr review "$PR_NUMBER" --approve
+          else
+            echo "PR was created by the bot, skipping review."
+          fi
+

.github/workflows/merge-main.yml

@@ -1,29 +0,0 @@
-name: Merge main into update-app-headers
-
-on:
-  push:
-    branches:
-      - main
-    paths:
-      - 'ct/**.sh'
-
-jobs:
-  merge-main:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v2
-
-      - name: Set up Git
-        run: |
-          git config --global user.name "GitHub Actions"
-          git config --global user.email "actions@github.com"
-
-      - name: Merge main into update-app-headers silently
-        run: |
-          git fetch origin
-          git checkout update-app-headers
-          git merge origin/main --allow-unrelated-histories --no-commit -m "Merge main into update-app-headers"
-          git push origin update-app-headers > /dev/null 2>&1 || true
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/shellcheck.yml

@@ -24,16 +24,12 @@ jobs:
         files: |
           **.sh
 
-    # This is a manual copy from https://github.com/ludeeus/action-shellcheck/blob/00b27aa7cb85167568cb48a3838b75f4265f2bca/action.yaml#L59
-    # Why? Because the action is not capable of adding ONLY a list of files.
-    # We aim to only check the files that have changed.
-    # This is used as we deal with a codebase that throws a lot of warnings.
-    # Checking only the changed files is a good compromise to improve the codebase over time.
-    - name: Download shellcheck
+    - name: Download ShellCheck
       shell: bash
       env:
         INPUT_VERSION: "v0.10.0"
       run: |
+        set -euo pipefail
         if [[ "${{ runner.os }}" == "macOS" ]]; then
           osvariant="darwin"
         else
@@ -41,22 +37,24 @@ jobs:
         fi
 
         baseurl="https://github.com/koalaman/shellcheck/releases/download"
-
-        curl -Lso "${{ github.action_path }}/sc.tar.xz" \
+        curl -Lso "${{ github.workspace }}/sc.tar.xz" \
           "${baseurl}/${INPUT_VERSION}/shellcheck-${INPUT_VERSION}.${osvariant}.x86_64.tar.xz"
 
-        tar -xf "${{ github.action_path }}/sc.tar.xz" -C "${{ github.action_path }}"
-        mv "${{ github.action_path }}/shellcheck-${INPUT_VERSION}/shellcheck" \
-          "${{ github.action_path }}/shellcheck"
+        tar -xf "${{ github.workspace }}/sc.tar.xz" -C "${{ github.workspace }}"
+        mv "${{ github.workspace }}/shellcheck-${INPUT_VERSION}/shellcheck" \
+          "${{ github.workspace }}/shellcheck"
 
-    - name: Display shellcheck version
-      shell: bash
+    - name: Verify ShellCheck binary
       run: |
-        "${{ github.action_path }}/shellcheck" --version
+        ls -l "${{ github.workspace }}/shellcheck"
+
+    - name: Display ShellCheck version
+      run: |
+        "${{ github.workspace }}/shellcheck" --version
 
     - name: Run ShellCheck
-      if: steps.changed-files-specific.outputs.any_changed == 'true'
+      if: steps.changed-files.outputs.any_changed == 'true'
       env:
         ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
       run: |
-        echo "${ALL_CHANGED_FILES}" | xargs shellcheck
+        echo "${ALL_CHANGED_FILES}" | xargs "${{ github.workspace }}/shellcheck"

CHANGELOG.md

@@ -16,6 +16,32 @@ All LXC instances created using this repository come pre-installed with Midnight
 > [!IMPORTANT]
 Do not break established syntax in this file, as it is automatically updated by a Github Workflow
 
+## 2025-01-14
+
+### Changed
+
+### 💥 Breaking Changes
+
+- Update tianji-install.sh: Add OPENAI_API_KEY to .env [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1480](https://github.com/community-scripts/ProxmoxVE/pull/1480))
+
+### ✨ New Scripts
+
+- New Script: Wordpress [@MickLesk](https://github.com/MickLesk) ([#1485](https://github.com/community-scripts/ProxmoxVE/pull/1485))
+- New Script: Opengist [@jd-apprentice](https://github.com/jd-apprentice) ([#1429](https://github.com/community-scripts/ProxmoxVE/pull/1429))
+
+### 🚀 Updated Scripts
+
+- Update lazylibrarian-install.sh: Add pypdf libary [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1467](https://github.com/community-scripts/ProxmoxVE/pull/1467))
+- Update opengist-install.sh: Add git as dependencie [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1471](https://github.com/community-scripts/ProxmoxVE/pull/1471))
+
+### 🌐 Website
+
+- [website] Update footer text [@rajatdiptabiswas](https://github.com/rajatdiptabiswas) ([#1466](https://github.com/community-scripts/ProxmoxVE/pull/1466))
+
+### 🧰 Maintenance
+
+- [core] Update build.func: Fix bug with advanced tags [@michelroegl-brunner](https://github.com/michelroegl-brunner) ([#1473](https://github.com/community-scripts/ProxmoxVE/pull/1473))
+
 ## 2025-01-13
 
 ### Changed

ct/wordpress.sh

@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
+# Copyright (c) 2021-2025 communtiy-scripts ORG
+# Author: MickLesk (Canbiz)
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Source: https://wordpress.org/
+
+## App Default Values
+APP="Wordpress"
+var_tags="blog;cms"
+var_disk="5"
+var_cpu="2"
+var_ram="2048"
+var_os="debian"
+var_version="12"
+
+# App Output & Base Settings
+header_info "$APP"
+base_settings
+
+# Core 
+variables
+color
+catch_errors
+
+function update_script() {
+    header_info
+    check_container_storage
+    check_container_resources
+    if [[ ! -d /var/www/html/wordpress ]]; then
+        msg_error "No ${APP} Installation Found!"
+        exit
+    fi
+    msg_error "Wordpress should be updated via the user interface."
+    exit
+}
+
+start
+build_container
+description
+
+msg_ok "Completed Successfully!\n"
+echo -e "${CREATING}${GN} ${APP} setup has been successfully initialized!${CL}"
+echo -e "${INFO}${YW} Access it using the following URL:${CL}"
+echo -e "${TAB}${GATEWAY}${BGN}http://${IP}/${CL}"

frontend/src/components/Footer.tsx

@@ -6,7 +6,7 @@ export default function Footer() {
     <div className="supports-backdrop-blur:bg-background/90 mt-auto flex border-t border-border bg-background/40 py-6 backdrop-blur-lg">
       <div className="flex w-full justify-between">
         <div className="mx-6 w-full max-w-7xl text-sm text-muted-foreground">
-          Website build by the community. The source code is avaliable on{" "}
+          Website built by the community. The source code is avaliable on{" "}
           <Link
             href={`https://github.com/community-scripts/${basePath}`}
             target="_blank"

install/opengist-install.sh

@@ -16,7 +16,8 @@ msg_info "Installing Dependencies"
 $STD apt-get install -y \
     mc \
     curl \
-    sudo
+    sudo \
+    git
 msg_ok "Installed Dependencies"
 
 msg_info "Install Opengist"
@@ -40,7 +41,7 @@ After=network.target
 
 [Service]
 WorkingDirectory=/opt/opengist
-ExecStart=/opt/opengist/opengist --config config.yaml
+ExecStart=/opt/opengist/opengist --config /opt/opengist/config.yml
 Restart=always
 User=root
 

install/tianji-install.sh

@@ -74,6 +74,7 @@ $STD pnpm build:server
 echo "${RELEASE}" >"/opt/${APPLICATION}_version.txt"
 cat <<EOF >/opt/tianji/src/server/.env
 DATABASE_URL="postgresql://$DB_USER:$DB_PASS@localhost:5432/$DB_NAME?schema=public"
+OPENAI_API_KEY=""
 JWT_SECRET="$TIANJI_SECRET"
 EOF
 cd /opt/tianji/src/server

install/wordpress-install.sh

@@ -0,0 +1,85 @@
+#!/usr/bin/env bash
+
+# Copyright (c) 2021-2025 communtiy-scripts ORG
+# Author: MickLesk (Canbiz)
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Source: https://wordpress.org/
+
+source /dev/stdin <<< "$FUNCTIONS_FILE_PATH"
+color
+verb_ip6
+catch_errors
+setting_up_container
+network_check
+update_os
+
+msg_info "Installing Dependencies (Patience)"
+$STD apt-get install -y \
+  curl \
+  unzip \
+  sudo \
+  mc \
+  apache2 \
+  php8.2-{bcmath,common,cli,curl,fpm,gd,snmp,imap,mbstring,mysql,xml,zip} \
+  libapache2-mod-php \
+  mariadb-server 
+ msg_ok "Installed Dependencies"
+
+msg_info "Setting up Database"
+DB_NAME=wordpress_db
+DB_USER=wordpress
+DB_PASS=$(openssl rand -base64 18 | tr -dc 'a-zA-Z0-9' | head -c13)
+$STD mysql -u root -e "CREATE DATABASE $DB_NAME;"
+$STD mysql -u root -e "CREATE USER '$DB_USER'@'localhost' IDENTIFIED BY '$DB_PASS';"
+$STD mysql -u root -e "GRANT ALL PRIVILEGES ON $DB_NAME.* TO '$DB_USER'@'localhost'; FLUSH PRIVILEGES;"
+{
+    echo "WordPress Credentials"
+    echo "Database User: $DB_USER"
+    echo "Database Password: $DB_PASS"
+    echo "Database Name: $DB_NAME"
+} >> ~/wordpress.creds
+msg_ok "Set up Database"
+
+msg_info "Installing Wordpress (Patience)"
+cd /var/www/html
+wget -q https://wordpress.org/latest.zip
+unzip -q latest.zip
+chown -R www-data:www-data wordpress/
+cd /var/www/html/wordpress
+find . -type d -exec chmod 755 {} \;
+find . -type f -exec chmod 644 {} \;
+mv wp-config-sample.php wp-config.php
+sed -i -e "s|^define( 'DB_NAME', '.*' );|define( 'DB_NAME', '$DB_NAME' );|" \
+       -e "s|^define( 'DB_USER', '.*' );|define( 'DB_USER', '$DB_USER' );|" \
+       -e "s|^define( 'DB_PASSWORD', '.*' );|define( 'DB_PASSWORD', '$DB_PASS' );|" \
+       /var/www/html/wordpress/wp-config.php
+msg_ok "Installed Wordpress"
+
+msg_info "Setup Services"
+cat <<EOF > /etc/apache2/sites-available/wordpress.conf
+<VirtualHost *:80>
+    ServerName yourdomain.com
+    DocumentRoot /var/www/html/wordpress
+
+    <Directory /var/www/html/wordpress>
+        AllowOverride All
+    </Directory>
+
+    ErrorLog \${APACHE_LOG_DIR}/error.log
+    CustomLog \${APACHE_LOG_DIR}/access.log combined
+
+</VirtualHost>
+EOF
+$STD a2ensite wordpress.conf
+$STD a2dissite 000-default.conf
+systemctl reload apache2
+msg_ok "Created Services"
+
+motd_ssh
+customize
+
+msg_info "Cleaning up"
+rm -rf /var/www/html/latest.zip
+$STD apt-get autoremove
+$STD apt-get autoclean
+msg_ok "Cleaned"

json/opengist.json

@@ -4,7 +4,7 @@
     "categories": [
         3
     ],
-    "date_created": "2025-11-01",
+    "date_created": "2025-01-14",
     "type": "ct",
     "updateable": false,
     "privileged": false,

json/wordpress.json

@@ -0,0 +1,34 @@
+{
+  "name": "Wordpress",
+  "slug": "wordpress",
+  "categories": [
+    14
+  ],
+  "date_created": "2025-01-14",
+  "type": "ct",
+  "updateable": true,
+  "privileged": false,
+  "interface_port": 80,
+  "documentation": "https://wordpress.org/documentation/",
+  "website": "https://wordpress.org/",
+  "logo": "https://s.w.org/style/images/about/WordPress-logotype-simplified.png",
+  "description": "WordPress is the simplest, most popular way to create your own website or blog. In fact, WordPress powers over 43.6% of all the websites on the Internet. Yes – more than one in four websites that you visit are likely powered by WordPress.\n\nOn a slightly more technical level, WordPress is an open-source content management system licensed under GPLv2, which means that anyone can use or modify the WordPress software for free.",
+  "install_methods": [
+    {
+      "type": "default",
+      "script": "ct/wordpress.sh",
+      "resources": {
+        "cpu": 2,
+        "ram": 2048,
+        "hdd": 5,
+        "os": "Debian",
+        "version": "12"
+      }
+    }
+  ],
+  "default_credentials": {
+    "username": null,
+    "password": null
+  },
+  "notes": []
+}

misc/.app-headers

@@ -1,4 +1,4 @@
-### Generated on 01-10-2025
+### Generated on 01-14-2025
 ##################################################
 
 ### 2fauth.sh
@@ -529,6 +529,15 @@ APP=Frigate
 /_/   /_/  /_/\__, /\__,_/\__/\___/ 
              /____/                 
 
+### ghost.sh
+APP=Ghost
+   ________               __ 
+  / ____/ /_  ____  _____/ /_
+ / / __/ __ \/ __ \/ ___/ __/
+/ /_/ / / / / /_/ (__  ) /_  
+\____/_/ /_/\____/____/\__/  
+                             
+
 ### gitea.sh
 APP=Gitea
    _______ __            
@@ -1222,6 +1231,15 @@ APP=OneDev
 \____/_/ /_/\___/_____/\___/|___/  
                                    
 
+### opengist.sh
+APP=Opengist
+   ____                         _      __ 
+  / __ \____  ___  ____  ____ _(_)____/ /_
+ / / / / __ \/ _ \/ __ \/ __ `/ / ___/ __/
+/ /_/ / /_/ /  __/ / / / /_/ / (__  ) /_  
+\____/ .___/\___/_/ /_/\__, /_/____/\__/  
+    /_/               /____/              
+
 ### openhab.sh
 APP=openHAB
                           __  _____    ____ 
@@ -1948,6 +1966,15 @@ APP=Wireguard
 |__/|__/_/_/   \___/\__, /\__,_/\__,_/_/   \__,_/   
                    /____/                           
 
+### wordpress.sh
+APP=Wordpress
+ _       __               __                         
+| |     / /___  _________/ /___  ________  __________
+| | /| / / __ \/ ___/ __  / __ \/ ___/ _ \/ ___/ ___/
+| |/ |/ / /_/ / /  / /_/ / /_/ / /  /  __(__  |__  ) 
+|__/|__/\____/_/   \__,_/ .___/_/   \___/____/____/  
+                       /_/                           
+
 ### yunohost.sh
 APP=YunoHost
 __  __                  __  __           __ 

misc/build.func

@@ -629,9 +629,14 @@ advanced_settings() {
 
   if ADV_TAGS=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Custom Tags?[If you remove all, there will be no tags!]" 8 58 ${TAGS} --title "Advanced Tags" 3>&1 1>&2 2>&3); then
     if [ -n "${ADV_TAGS}" ]; then
-        ADV_TAGS=${ADV_TAGS:-""} 
-        ADV_TAGS=$(echo "$ADV_TAGS" | tr -d '[:space:]')
+      ADV_TAGS=$(echo "$ADV_TAGS" | tr -d '[:space:]') # Remove whitespace from ADV_TAGS
+      if [[ "$ADV_TAGS" != *"community-script"* ]]; then
         TAGS="community-script;${ADV_TAGS}"
+      else
+        TAGS="${ADV_TAGS}" # ADV_TAGS already contains "community-script"
+      fi
+    else
+      TAGS="community-script;"
     fi
       echo -e "${NETWORK}${BOLD}${DGN}Tags: ${BGN}$TAGS${CL}"
     else