From 7363c7358f68bf6c6afe74458e6cb3209f824b71 Mon Sep 17 00:00:00 2001
From: Denys Holius <d.holius@victoriametrics.com>
Date: Wed, 18 Dec 2024 18:15:28 +0200
Subject: [PATCH] apply suggestions

---
 ct/victoriametrics.sh              |  6 +++---
 install/victoriametrics-install.sh | 24 ++++++++++++++----------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/ct/victoriametrics.sh b/ct/victoriametrics.sh
index 88a648bc..09e634c1 100644
--- a/ct/victoriametrics.sh
+++ b/ct/victoriametrics.sh
@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 source <(curl -s https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
-# Copyright (c) 2021-2024 tteck
-# Author: tteck (tteckster)
+# Copyright (c) 2021-2024 community-scripts ORG
+# Author: Denys Holius https://github.com/denisgolius
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://prometheus.io/
+# Source: https://victoriametrics.com/
 
 # App Default Values
 APP="VictoriaMetrics"
diff --git a/install/victoriametrics-install.sh b/install/victoriametrics-install.sh
index ae74e93f..fbaf6d0e 100644
--- a/install/victoriametrics-install.sh
+++ b/install/victoriametrics-install.sh
@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-# Copyright (c) 2021-2024 tteck
-# Author: tteck (tteckster)
-# License: MIT
-# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Copyright (c) 2021-2024 community-scripts ORG
+# Author: Denys Holius https://github.com/denisgolius
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Source: https://victoriametrics.com/
 
 source /dev/stdin <<< "$FUNCTIONS_FILE_PATH"
 color
@@ -14,9 +14,11 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y curl
-$STD apt-get install -y sudo
-$STD apt-get install -y mc
+$STD apt install -y \
+          curl \
+          sudo \
+          mc
+
 msg_ok "Installed Dependencies"
 
 msg_info "Installing VictoriaMetrics"
@@ -46,8 +48,8 @@ echo "${RELEASE}" >/opt/${APPLICATION}_version.txt
 msg_ok "Installed VictoriaMetrics"
 
 msg_info "Creating Service"
-service_path="/etc/systemd/system/victoriametrics.service"
-echo "[Unit]
+cat <<EOF >/etc/systemd/system/victoriametrics.service
+[Unit]
 Description=VictoriaMetrics is a fast, cost-effective and scalable monitoring solution and time series database.
 # https://docs.victoriametrics.com
 # See https://docs.victoriametrics.com/#list-of-command-line-flags to get more information about supported command-line flags
@@ -79,7 +81,9 @@ StandardError=syslog
 SyslogIdentifier=victoriametrics
 
 [Install]
-WantedBy=multi-user.target" >$service_path
+WantedBy=multi-user.target
+EOF
+
 systemctl enable -q --now victoriametrics
 msg_ok "Created Service"