Centralize all standard LXC options to avoid code duplication

This commit is contained in:
Rémi Bédard-Couture 2024-11-17 22:09:33 -05:00
parent 61d2e0d599
commit 0e9623b662

View File

@ -129,6 +129,37 @@ ssh_check() {
fi fi
} }
# This function allows to centralize all common options so that services only need to define settings that need to be overridden (Avoid duplication of information)
base_settings() {
CT_TYPE="1"
PW=""
CT_ID=$NEXTID
HN=$NSAPP
DISK_SIZE="4"
CORE_COUNT="1"
RAM_SIZE="512"
BRG="vmbr0"
NET="dhcp"
GATE=""
APT_CACHER=""
APT_CACHER_IP=""
DISABLEIP6="no"
MTU=""
SD=""
NS=""
MAC=""
VLAN=""
SSH="no"
VERB="no"
# Since these 2 are defined outside of default_settings function, avoid overwriting them. To align everything, they should use another constant variable (say OSTYPE), but that would require updating the default_settings function for all existing scripts
if [ -z "$var_os" ]; then
var_os="debian"
fi
if [ -z "$var_version" ]; then
var_version="12"
fi
}
# This function displays the default values for various settings. # This function displays the default values for various settings.
echo_default() { echo_default() {
echo -e "${DGN}Using Distribution: ${BGN}$var_os${CL}" echo -e "${DGN}Using Distribution: ${BGN}$var_os${CL}"
@ -491,6 +522,7 @@ install_script() {
NEXTID=$(pvesh get /cluster/nextid) NEXTID=$(pvesh get /cluster/nextid)
timezone=$(cat /etc/timezone) timezone=$(cat /etc/timezone)
header_info header_info
base_settings
if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "SETTINGS" --yesno "Use Default Settings?" --no-button Advanced 10 58); then if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "SETTINGS" --yesno "Use Default Settings?" --no-button Advanced 10 58); then
header_info header_info
echo -e "${BL}Using Default Settings${CL}" echo -e "${BL}Using Default Settings${CL}"