From 0059adecf1b2cce827e652aedefbc53679a3e672 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastiaan?= Date: Wed, 8 Jan 2025 21:41:58 +0100 Subject: [PATCH] fix(ci): formatting event & chmod +x (#1335) --- .github/workflows/validate-formatting.yaml | 4 ++-- .github/workflows/validate-scripts.yml | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/validate-formatting.yaml b/.github/workflows/validate-formatting.yaml index c0b6ef3b..22056397 100644 --- a/.github/workflows/validate-formatting.yaml +++ b/.github/workflows/validate-formatting.yaml @@ -38,7 +38,7 @@ jobs: - name: Get changed files id: changed-files run: | - if ${{ github.event_name == 'pull_request' }}; then + if ${{ github.event_name == 'pull_request_target' }}; then echo "files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ steps.pr.outputs.result && fromJSON(steps.pr.outputs.result).merge_commit_sha }} | grep -E '\.(sh|func)$' | xargs)" >> $GITHUB_OUTPUT else echo "files=$(git diff --name-only ${{ github.event.before }} ${{ github.event.after }} | grep -E '\.(sh|func)$' | xargs)" >> $GITHUB_OUTPUT @@ -70,7 +70,7 @@ jobs: fi - name: Post comment with results - if: always() && steps.changed-files.outputs.files != '' && github.event_name == 'pull_request' + if: always() && steps.changed-files.outputs.files != '' && github.event_name == 'pull_request_target' uses: actions/github-script@v7 with: script: | diff --git a/.github/workflows/validate-scripts.yml b/.github/workflows/validate-scripts.yml index 0df07a74..c58a5e59 100644 --- a/.github/workflows/validate-scripts.yml +++ b/.github/workflows/validate-scripts.yml @@ -33,10 +33,6 @@ jobs: with: fetch-depth: 0 # Ensure the full history is fetched for accurate diffing ref: ${{ github.event_name == 'pull_request_target' && fromJSON(steps.pr.outputs.result).merge_commit_sha || '' }} - - - name: Set execute permission for .sh files - run: | - chmod +x ct/*.sh - name: Get changed files id: changed-files